Remove if / else in url_changeset (The 'comp' operator works for both multiview and non-multiview mode)

Updated French translations

Move text formatting for some language strings to config page

WebSVN: refactoring using http_build_query

Added explanatory text for private bugnotes setting ...

bugnote_add() API will force VS_PUBLIC state if changeset's author does
not have private_bugnote_threshold.

Use Selection list to pick bugfix notes view state ...

To be consistent with MantisBT core, the bugnote view status is now set
by means of a selection list (i.e. pick public/private) instead of a
checkbox.

Added option to select view state of bug notes ...

Prior to this, the 'Bug fix' notes view state was hardcoded to public.
We are now allowing the administrator to choose whether they should be
public or private by means of a config option.

Fixes #42

Cyril's original commits were squashed.

Signed-off-by: Damien Regad <damien.regad@merckgroup.com>

Partial revert "Replace uses of config_get() by calls to plugin_config_get()" ...

This partially reverts commit 9222599.

It is required that we use config_get() referencing the 'Source' plugin
in SourceIntegration.php. Because SourceIntegration is a child plugin of
Source, plugin_config_get() does not refer to the correct config string
when retrieving the setting, causing 'Configuration option not found'
errors to occur.

Replace uses of config_get() by calls to plugin_config_get()

WebSVN: differentiated URLs depending on multiviews option ...

The plugin is now able to handle both types of WebSVN URLs:

- standard URLs, e.g.
  http://example.com/listing.php?repname=MyRepo&path=%2Ftrunk%2F&rev=10&sc=1
- multiview URLs (introduced with 577ff7e) like
  http://example.com/MyRepo/trunk?&rev=10

This commit restores the WebSVN functionality for sites not using the
multiviews functionality (i.e. as thigs were prior to commit
577ff7e).

Fixes #46

WebSVN: added helper methods to retrieve repo info ...

get_websvn_url, get_websvn_name, get_websvn_path

WebSVN: add is_multiviews method

WebSVN : Add option to handle "Multiview" mode ...

WebSVN can be configured to use Apache Multiview link format [1]. This
commit allows users to specify if this option is enabled or not in the
settings page of their WebSVN repositories.

Note that theses changes only make the option visible in the WebSVN
repos config, but does not alter the plugin's behavior. The next step
is to check the value of this option so the plugin can format WebSVN
links as appropriate.

[1] http://httpd.apache.org/docs/current/content-negotiation.html#multiviews

Fixes #46, #47

Original code was modified to use check_checked() function and fix
whitespace, commmit message reworded.

Signed-off-by: Damien Regad <damien.regad@merckgroup.com>

Improve display of repository 'Extra Info' field ...

Instead of a foreach loop and individual call to var_dump() on each
element of the info array, we now call var_dump() on the array itself,
so that the displayed information is more easy to read.

Github: Fix PHP system notices ...

- Undefined index: hub_app_access_token in api_uri()
  ==> added isset() check
- Undefined property: stdClass::$id in json_commit_changeset()
  ==> use 'sha' instead of 'id'

Bumping version numbers ...

Core framework version -> 0.18
Github -> 0.17
Gitweb -> 0.17
WebSVN -> 0.17

Github: update language strings following fix for #34

Github: Wrong comparison of repository name ...

On Github the repository names are not required to be lowercase. The
repository name send in the payload-data by Github could be something
like 'RePo-SiTory_NamE'.

In that case the comparison will fail and no import is possible.

Fixes #34

Signed-off-by: Damien Regad <damien.regad@merckgroup.com>

Gitweb: Don't use PHP_EOL when parsing output ...

PHP_EOL is valid only for the current instance of PHP, while Gitweb is
perl and potentially running on a different architecture.  Filter CR/LF
explicitly instead.

Fixes #40

"Bug Fixed Assign To Committer" option not saved when checkbox unchecked ...

Fixes #44

Signed-off-by: Damien Regad <damien.regad@merckgroup.com>

WebSVN: fix broken links ...

Prior to this, every link to WebSVN (v.2.3.3) created unrendered
template pages. This changes URLs from 'websvn/action.php?path=&repo='
form to 'websvn/repo/path?op=' form.

Fixes #46

Simplify user-parsing code ...

Function Source_Parse_Users() was simplified by removing nearly
identical code to process the author and committer to a generic function
handling this task for both types of users.

Changesets store author's id instead of committer ...

When a commit is authored by A and committed by B, Source_Parse_Users()
function incorrectly sets A's id instead of B's as the committer,
resulting in incorrect changeset information being stored in the DB.

Fixes #44

Fix whitespace

Add ChangeSet viewer support

Change WebSVN urls

Remove duplicated language string

Remove executable mode from english language file

Fix a number of bugs, support listing files modified ...

Ton Plomp contributed a patch in June 2010 to resolve a bug whereby
automatic additions of changesets were not working. Another bug with
incorrect timezone offsets was also resolved. Finally, Ton's patch also
allows for the author email address to be unspecified on a commit.

In October 2010 Marcel Bennett reviewed Ton's patch and made a few minor
changes/corrections. Marcel has also added the ability for the
SourceHgWeb plugin to retrieve a list of files modified in a commit.

I have modified the patch to escape variables before outputting them so
that this plugin is safe from potential XSS vulnerabilities.

Co-authored-by: Ton Plomp <tcplomp@gmail.com>
Co-authored-by: Marcel Bennett <marcel@iamserious.com>

Update HgWeb plugin to work with Source 0.14